fix(ingest): only populate audit stamps where accurate

[hsheth2]

We used to use created as a fallback for lastModified (or vice versa). This fixes that up across our warehouse and BI sources, so that we can actually trust the info in the model.

Checklist

• [ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• [ ] Links to related issues (if applicable)
• [ ] Tests for the changes have been added/updated (if applicable)
• [ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• [ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• Bug Fixes

  • Standardized the created field to None across multiple sources and schemas (Metabase, Redash, Redshift, Snowflake, Superset) for consistency and due to missing created_by data.

• Tests

  • Updated test data and logic to reflect the changes in created field handling, ensuring accuracy in test scenarios for Metabase, Superset, and Redash integration tests.

• Chores

  • Cleaned up conditional checks and simplified logic for setting lastModified properties in various ingestion sources.

[coderabbitai[bot]]

Walkthrough

This update emphasizes standardizing the handling of the created field across various metadata ingestion sources, namely Metabase, Redash, Redshift, Snowflake, and Superset. The created field is consistently being set to None due to the lack of reliable creation timestamps in the source data. Additionally, the corresponding test files and golden JSONs have been updated to reflect these changes, ensuring consistency and correctness of the tests.

Changes

Files	Change Summary
metadata-ingestion/src/datahub/ingestion/source/metabase.py	Changed created field assignment to None in construct_card_from_api_data.
metadata-ingestion/src/datahub/ingestion/source/redash.py	Set created to None in _get_dashboard_snapshot and _get_chart_snapshot.
metadata-ingestion/src/datahub/ingestion/source/redshift/redshift.py	Simplified logic for lastModified attribute, setting lastModified to None.
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py	Simplified setting of lastModified property, assigning None when table.last_altered is None.
metadata-ingestion/src/datahub/ingestion/source/superset.py	Set created to None in construct_dashboard_from_api_data and construct_chart_from_chart_data.
metadata-ingestion/tests/integration/metabase/metabase_mces_golden.json	Updated time to 0 and actor to "urn:li:corpuser:unknown".
metadata-ingestion/tests/integration/superset/golden_test_ingest.json	lastModified updated and added lastRunId in systemMetadata.
metadata-ingestion/tests/integration/superset/golden_test_stateful_ingest.json	Updated multiple time and actor entries.
metadata-ingestion/tests/unit/test_redash_source.py	Set created field to None across multiple test functions.

Poem

In the realm of metadata so bright,
Changes have taken their flight.
From timestamps to the actor's role,
To "None" they yield, making the whole.
A rabbit hops, coding delight,
Celebrating changes day and night! 🌟🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[hsheth2]

Airflow tests are flakes from a while ago.