[Tableau] workbook fetches the `id` field when the rest of project/dashboard/chart fetches the `luid` field

[hhong96]

Describe the bug There are two id fields that can be obtained from Tableau API. one is id and the other is luid. During Tableau ingestion, each level of entity (project, dashboard, and chart) follows a pattern where id field goes to the part of urn (i.e., urn:li:container:c1ab242005aa37f71b5927f399797c6c) and luid is appended to the property of an entity (i.e., project_id: '6ed17450-0108-4234-903f-23bf7d7f70ae'). Only the Workbook entity does not follow this pattern. The urn seems to be randomly generated, and id field is being appended to the property. This leaves us without having luid field for workbook, which is what Tableau REST API only accepts as unique identifier.

To Reproduce Steps to reproduce the behavior:

1. Ingest Tableau data source.
2. Compare the urn/property with the actual Tableau API query result.

Expected behavior Workbook should have id field as urn, append luid to the property, keeping the consistency with the other entities.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• Mac OS
• Chrome
• 0.13.0

Additional context Add any other context about the problem here.

[hsheth2]

@hhong96 the workbook urns are a guid generated by combining the platform, platform instance, and id (not luid). See usages of WorkbookKey in the code e.g. https://github.com/datahub-project/datahub/blob/e6e5c091ed7b7c8ca73b062cec92d0c3cacc02e7/metadata-ingestion/src/datahub/ingestion/source/tableau.py#L2425

I'd rather not change the way to construct urns since that'd be a breaking change, but I would definitely be open to adding some custom properties to the workbook container

Is that something you could open a PR for?

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

[github-actions[bot]]

This issue was closed because it has been inactive for 30 days since being marked as stale.