datafusion-objectstore-s3 icon indicating copy to clipboard operation
datafusion-objectstore-s3 copied to clipboard

Create python bindings

Open matthewmturner opened this issue 3 years ago • 7 comments

matthewmturner avatar Feb 01 '22 04:02 matthewmturner

i guess this can be combined in datafusion-python repo

jimexist avatar Feb 01 '22 07:02 jimexist

@Jimexist that would certainly decrease time to market. In the short run I think its a great idea.

and just to confirm, are you referring to make it part of the same datafusion python package? or a separate package like datafusion-s3?

@seddonm1 any thoughts?

matthewmturner avatar Feb 01 '22 14:02 matthewmturner

Sorry I have zero knowledge of the Python bindings.

The only benefit of separating it from the datafusion-python repo may be if users don't want to install certain components (for example a GCP user may not need S3)?

seddonm1 avatar Feb 01 '22 21:02 seddonm1

something we can consider is to make sure this repo's python API is compatible with the one from datafusion-python, and then allow it to be installed via extras:

  • https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies
  • https://python-poetry.org/docs/pyproject/#extras

In this way, users can do:

pip install datafusion datafusion[s3] datafusion[gcp]

jimexist avatar Feb 02 '22 08:02 jimexist

@Jimexist i think thats a good idea. I will look into it.

matthewmturner avatar Feb 02 '22 15:02 matthewmturner

+1 for this!

chitralverma avatar Jun 25 '22 06:06 chitralverma

+1 for this

schapala-hm avatar Oct 11 '22 00:10 schapala-hm