databend icon indicating copy to clipboard operation
databend copied to clipboard

chore: use cargo workspace inheritance

Open TennyZhuang opened this issue 2 years ago • 8 comments

Signed-off-by: TennyZhuang [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

A new cargo feature stabilized in Rust 1.64, see https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace

It works well on the recent toolchain and have nice editor support on VSCode.

TennyZhuang avatar Sep 22 '22 14:09 TennyZhuang

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

vercel[bot] avatar Sep 22 '22 14:09 vercel[bot]

Announced in Rust 1.64. https://blog.rust-lang.org/2022/09/22/Rust-1.64.0.html

TennyZhuang avatar Sep 22 '22 14:09 TennyZhuang

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Sep 25, 2022 at 0:25AM (UTC)

vercel[bot] avatar Sep 22 '22 14:09 vercel[bot]

It seems that we may also have to bump the cargo-udeps.

TennyZhuang avatar Sep 22 '22 15:09 TennyZhuang

Announced in Rust 1.64. https://blog.rust-lang.org/2022/09/22/Rust-1.64.0.html

We are using 1.66 (nightly) now. This feature should be available.

It seems that we may also have to bump the cargo-udeps.

Let me take a look.

Xuanwo avatar Sep 22 '22 15:09 Xuanwo

Can you help upgrade cargo-udeps to the latest version? thanks!

https://github.com/datafuselabs/databend/blob/e03366fa68babb0da237eb5609e13e04e287c3b4/scripts/setup/rust-tools.txt#L2

Xuanwo avatar Sep 22 '22 15:09 Xuanwo

Wait for https://github.com/datafuselabs/databend/pull/7815

Xuanwo avatar Sep 23 '22 01:09 Xuanwo

The latest cargo-udeps still requires a feature flag.

TennyZhuang avatar Sep 23 '22 01:09 TennyZhuang