databend icon indicating copy to clipboard operation
databend copied to clipboard

cannot pass `make lint` after `cargo update`

Open ClSlaid opened this issue 3 years ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Version

d747a6c

What's Wrong?

After cargo update all dependency cache, make lint will fail on checking common-hive-meta-store:

error[E0432]: unresolved import `thrift::protocol::TSerializable`
  --> /databend/target/debug/build/common-hive-meta-store-a3775ca046a58940/out/hms_patched.rs:16:142
   |
16 | ...ssageType, TInputProtocol, TOutputProtocol, TSerializable, TSetIdentifier, TStructIdentifier, TType};
   |                                                ^^^^^^^^^^^^^ no `TSerializable` in `protocol`

How to Reproduce?

check out the latest main branch like d747a6c, and run cargo update, then make lint.

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

ClSlaid avatar Sep 22 '22 11:09 ClSlaid

Thrift released v0.17 serval days ago, but its rust lib is not updated. If you are using Archlinux, please rollback to v0.16 until the upstream fixed this problem.

Xuanwo avatar Sep 22 '22 11:09 Xuanwo

Already fixed.

Xuanwo avatar Nov 10 '22 15:11 Xuanwo