databend icon indicating copy to clipboard operation
databend copied to clipboard

Hide password in query log

Open drmingdrmer opened this issue 3 years ago • 2 comments

Password in query log will be displayed in plain text. It should be replaced with something like ***:

   68 2022-05-26T05:53:51.880269Z  INFO databend_query::servers::mysql::mysql_interactive_worker: Normal query: create user 'myadmin'@'%' identified by 'aaaaaa'

drmingdrmer avatar May 26 '22 06:05 drmingdrmer

Is this issue still valid?

Xuanwo avatar Sep 16 '22 06:09 Xuanwo

It looks like it is: https://github.com/datafuselabs/databend/blob/f59efc05bc080e762846fbe8bac24c806e432a75/src/query/service/src/servers/mysql/mysql_interactive_worker.rs#L335

@youngsofun

drmingdrmer avatar Sep 16 '22 06:09 drmingdrmer

  • [ ] mysql handler
    • [ ] should let client send hash?
  • [ ] http handlers
    • [ ] middleware
  • [ ] parser: turn into hash in plan

youngsofun avatar Oct 07 '22 03:10 youngsofun

Done

BohuTANG avatar May 29 '24 08:05 BohuTANG