databend icon indicating copy to clipboard operation
databend copied to clipboard
verified publisher icon datafuselabs

feat: Add start after for LIST STAGE

Open Xuanwo opened this issue 1 year ago โ€ข 7 comments

Signed-off-by: Xuanwo [email protected]I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

  • Part of https://github.com/datafuselabs/databend/issues/14710

Tests

  • [x] Unit Test
  • [ ] Logic Test
  • [ ] Benchmark Test
  • [ ] No Test - Explain why

Type of change

  • [ ] Bug Fix (non-breaking change which fixes an issue)
  • [x] New Feature (non-breaking change which adds functionality)
  • [ ] Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • [ ] Documentation Update
  • [ ] Refactoring
  • [ ] Performance Improvement
  • [ ] Other (please describe):

This change isโ€‚Reviewable

Xuanwo avatar Mar 18 '24 10:03 Xuanwo

Conflicting files src/query/service/src/interpreters/interpreter_copy_into_location.rs

BohuTANG avatar Mar 21 '24 01:03 BohuTANG

need logic tests for list statment, and list_stage, infer_schema table function?

youngsofun avatar Apr 30 '24 02:04 youngsofun

need logic tests for list statment, and list_stage, infer_schema table function?

This only works for s3 stage, I will add some tests for them.

Xuanwo avatar Apr 30 '24 07:04 Xuanwo

need logic tests for list statment, and list_stage, infer_schema table function?

This only works for s3 stage, I will add some tests for them.

I thought opendal provide implementation on top of the raw backend? otherwise, if start-after only support for s3, databend should check for the backend of the stage and report error if the stage is not s3?

youngsofun avatar Apr 30 '24 08:04 youngsofun

otherwise, if start-after only support for s3, databend should check for the backend of the stage and report error if the stage is not s3?

We should check op.capability().list_with_start_after. Let me add it.

Xuanwo avatar Apr 30 '24 09:04 Xuanwo

Suggestion: This PR appears not ready for review as it lacks logic or unit tests. I'll set it to draft status :)

BohuTANG avatar Jun 02 '24 01:06 BohuTANG

Suggestion: This PR appears not ready for review as it lacks logic or unit tests. I'll set it to draft status :)

Thanks! I'll return once I've handled other more urgent tasks.

Xuanwo avatar Jun 02 '24 06:06 Xuanwo