databend icon indicating copy to clipboard operation
databend copied to clipboard

fix: improve error hints when select * from xx.yy

Open zhenglin-charlie-li opened this issue 1 year ago โ€ข 2 comments

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

  • Fixes https://github.com/datafuselabs/databend/issues/13718

Tests

  • [ ] Unit Test
  • [x] Logic Test
  • [ ] Benchmark Test
  • [ ] No Test - Explain why

Type of change

  • [x] Bug Fix (non-breaking change which fixes an issue)
  • [ ] New Feature (non-breaking change which adds functionality)
  • [ ] Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • [ ] Documentation Update
  • [ ] Refactoring
  • [ ] Performance Improvement
  • [ ] Other (please describe):

This change isโ€‚Reviewable

zhenglin-charlie-li avatar Feb 18 '24 01:02 zhenglin-charlie-li

build failed due to incorrect codes.

sundy-li avatar Feb 24 '24 06:02 sundy-li

LGTM, Can you add logic tests to cover the issue case ?

sundy-li avatar Feb 25 '24 08:02 sundy-li

@sundy-li Hi๏ผŒthanks for your comments. Could I ask where can i add such test?

zhenglin-charlie-li avatar Mar 18 '24 16:03 zhenglin-charlie-li

You can add a new test like issue_13718.test in https://github.com/datafuselabs/databend/tree/main/tests/sqllogictests/suites/base/issues.

bohutang avatar Mar 19 '24 00:03 bohutang