databend icon indicating copy to clipboard operation
databend copied to clipboard

chore(query): remove codes of storage/parquet2

Open sundy-li opened this issue 2 years ago โ€ข 1 comments

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Remove codes of storage/parquet2, and make setting use_parquet2 deprecated. Let's always use parquet-rs cause it's stable.

Fixes #[Link the issue here]

Tests

  • [x] Unit Test
  • [x] Logic Test
  • [ ] Benchmark Test
  • [ ] No Test - Explain why

Type of change

  • [ ] Bug Fix (non-breaking change which fixes an issue)
  • [ ] New Feature (non-breaking change which adds functionality)
  • [ ] Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • [ ] Documentation Update
  • [x] Refactoring
  • [ ] Performance Improvement
  • [ ] Other (please describe):

This change isโ€‚Reviewable

sundy-li avatar Jan 11 '24 14:01 sundy-li

Convert to draft, let's wait some tools(generate parquet files, which will be COPY by Databend) from parquet2 to parquet-rs.

bohutang avatar Jan 12 '24 07:01 bohutang

@BohuTANG It's ready to continue. Both are already compatible, I don't want to solve lots of conflicts weeks later.

sundy-li avatar Feb 29 '24 03:02 sundy-li