data-diff icon indicating copy to clipboard operation
data-diff copied to clipboard

Published 20 hours ago • verified publisher icon datafold

Namespacing CLI options

Open sar009 opened this issue 1 year ago • 7 comments

The __main__.py is blotted with a lot of CLI variables impacting readability and loose typing. So namespacing the CLI options under the class CliOptions.

sar009 avatar Jan 25 '24 12:01 sar009

fixing https://github.com/datafold/data-diff/issues/859

sar009 avatar Jan 25 '24 18:01 sar009

Can you add a fuller description on your approach in this PR? I'll plan to review this next week when it's ready!

sungchun12 avatar Jan 25 '24 18:01 sungchun12

@sungchun12 I have updated the description please have a look.

sar009 avatar Jan 25 '24 19:01 sar009

@sungchun12 I have addressed the review comments please take a look

sar009 avatar Feb 20 '24 10:02 sar009

@sar009 thank you! I'll review later this week.

sungchun12 avatar Feb 20 '24 15:02 sungchun12

Mirror this PR for the full test suite to uncover any edge cases: https://github.com/datafold/data-diff/pull/871

sungchun12 avatar Feb 26 '24 23:02 sungchun12

This pull request has been marked as stale because it has been open for 60 days with no activity. If you would like the pull request to remain open, please comment on the pull request and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar May 10 '24 06:05 github-actions[bot]

Although we are closing this pull request as stale, it's not gone forever. PRs can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

github-actions[bot] avatar May 17 '24 06:05 github-actions[bot]