data-diff icon indicating copy to clipboard operation
data-diff copied to clipboard

Add support for Athena

Open johanjvrens opened this issue 1 year ago • 1 comments

Hi, Is Athena in the pipeline to be added as a Supported Databases?

Regards Johan

johanjvrens avatar Jul 07 '22 13:07 johanjvrens

Hi @johanjvrens ,

Athena is currently not considered a high priority, but we might implement it if the demand is high (please vote 👍🏼 for feature requests).

However, contributions are very welcome! If you'd like to try, we'll be happy to help you in the process.

erezsh avatar Jul 13 '22 14:07 erezsh

Would love to know more about how to get this going, we're possibly open to taking it on

niger-prequel avatar Oct 07 '22 14:10 niger-prequel

Hi @niger-prequel , that's great to hear.

To get started, read these:

  1. https://github.com/datafold/data-diff/blob/master/CONTRIBUTING.md

  2. https://data-diff.readthedocs.io/en/latest/new-database-driver-guide.html

Also, ideally you would add Athena to docker-compose.yml, so that docker-compose up athena would set it up to pass the tests.

If you have any questions, or need advice, feel free to ask!

erezsh avatar Oct 07 '22 14:10 erezsh

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar May 28 '23 06:05 github-actions[bot]

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

github-actions[bot] avatar Jun 04 '23 06:06 github-actions[bot]

+1

osalloum avatar Jun 24 '23 06:06 osalloum