datafaker icon indicating copy to clipboard operation
datafaker copied to clipboard

Published 20 hours ago • verified publisher icon datafaker-net

European makes and models for cars

Open jaapcoomans opened this issue 2 years ago • 6 comments

I'm currently using the Vehicle faker to generate car makes and models. What I noticed, is that currently primarily US models and makes are included in the default configuration.

Now I could go and add some more European makes and models to one or more locale files, but that does not feel right. While there are differences in markets at large (US / Europe / Asia, probably some more), this is a subject that's not strictly bound to a single locale. Also in our use case we use several locale's from around Europe.

What would be the best way forward here?

  • Use the locales as they are right now and just reproduce makes and models over many locale files?
  • Add specific methods to the Vehicle faker for European makes and models?
  • Something completely different...?

To be clear: I'd be happy to contribute and file PR, I'm just wondering what direction I should / could take with this one.

jaapcoomans avatar Sep 13 '22 06:09 jaapcoomans

Hi @jaapcoomans , great to see you here. I just had a look at vehicle.yml, and while the list of manufacturers is quite large, the makes and models are not.

I think the best way forward would be to add more makes and models to the vehicle.yml locale, I don't see an issue with that. PR on this certainly welcome!

(I've just added a few Tesla models to the data)

bodiam avatar Sep 13 '22 09:09 bodiam

By the way a few words about how these tasks could be solved

  1. A new provider or update an existing one in upstream.
  2. datafaker supports custom providers. That means that people don't have to wait for a new release to start use their providers and use it from same datafaker like any other provider. For more info about custom providers please have a look here https://www.datafaker.net/documentation/custom-providers/

And yes contributions are more than welcome

snuyanzin avatar Sep 13 '22 09:09 snuyanzin

@snuyanzin in my understanding this is more about updating an existing provider, the Vehicle provider (which is lacking a bit of content) than adding a new provider.

bodiam avatar Sep 13 '22 10:09 bodiam

@bodiam Thanks for thinking along! My question was indeed about extending the Vehicle provider. I think you're right, adding more makes and models to the vehicle.yaml is the best approach. Expect a PR soon 🙂

Also, TIL that the things I used to call Fakers are actually called Providers. I'll update my vocabulary 👍

jaapcoomans avatar Sep 13 '22 10:09 jaapcoomans

@jaapcoomans Well, you don't have to update your vocabulary, there's not really a clear agreement on them I think. I call Datafaker a faker, and something like a Vehicle thing a provider of data, or, provider in short. But if you want to call it a faker because it generates fake vehicles, I can understand that, I just find it slightly ambiguous when talking about a Faker if we mean the Faker class, or a Data faker, so, Provider it is.

bodiam avatar Sep 13 '22 11:09 bodiam

@jaapcoomans sorry to bother, but any updates on this?

bodiam avatar Sep 23 '22 08:09 bodiam

@bodiam I was afk for a while for various reasons. But now I have some time at my hand again. PR incoming...

jaapcoomans avatar Sep 23 '22 14:09 jaapcoomans

Hi Jaap, I think we should be good for now? I've also added things like Mazda, Nio, Xpeng, etc, hope that gives a more rich set of data

(https://github.com/datafaker-net/datafaker/pull/386)

bodiam avatar Sep 24 '22 07:09 bodiam