datafaker icon indicating copy to clipboard operation
datafaker copied to clipboard

Fix phone number formats for en-GB

Open panilya opened this issue 3 years ago • 3 comments

Issue: #163 Minimized error code to +-10

panilya avatar Aug 04 '22 15:08 panilya

Codecov Report

Merging #274 (19737b5) into master (94d9955) will increase coverage by 0.41%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #274      +/-   ##
============================================
+ Coverage     94.26%   94.68%   +0.41%     
- Complexity     1881     1892      +11     
============================================
  Files           195      195              
  Lines          3819     3819              
  Branches        391      391              
============================================
+ Hits           3600     3616      +16     
+ Misses          117      103      -14     
+ Partials        102      100       -2     
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.92% <0.00%> (+0.60%) :arrow_up:
src/main/java/net/datafaker/Internet.java 90.41% <0.00%> (+1.36%) :arrow_up:
src/main/java/net/datafaker/Address.java 97.14% <0.00%> (+2.85%) :arrow_up:
src/main/java/net/datafaker/Commerce.java 100.00% <0.00%> (+4.00%) :arrow_up:
src/main/java/net/datafaker/IdNumber.java 100.00% <0.00%> (+6.66%) :arrow_up:
src/main/java/net/datafaker/Lorem.java 97.91% <0.00%> (+8.33%) :arrow_up:
...ava/net/datafaker/HitchhikersGuideToTheGalaxy.java 100.00% <0.00%> (+11.11%) :arrow_up:
src/main/java/net/datafaker/OscarMovie.java 100.00% <0.00%> (+16.66%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 04 '22 15:08 codecov-commenter

@snuyanzin seems the concurrent tests are still flaky

bodiam avatar Aug 04 '22 16:08 bodiam

looks like i forgot one field currently playing with https://github.com/datafaker-net/datafaker/pull/275 in case it will not fail after a bunch of runs i'll merge it

snuyanzin avatar Aug 04 '22 17:08 snuyanzin