website icon indicating copy to clipboard operation
website copied to clipboard

Published 20 hours ago • verified publisher icon datacommonsorg

deprecate userMessage

Open chejennifer opened this issue 1 year ago • 2 comments

Now that UN has switched over to using userMessages, deprecating userMessage in NL response

chejennifer avatar May 03 '24 19:05 chejennifer

They've rolled it out to their staging instance, but not prod. We could wait to merge this until it reaches prod

dwnoble avatar May 03 '24 20:05 dwnoble

They've rolled it out to their staging instance, but not prod. We could wait to merge this until it reaches prod

Ok, I can wait until it reaches prod, can you let me know?

chejennifer avatar May 03 '24 20:05 chejennifer

This PR looks good to merge. UN updated the site on their end to migrate from userMessage to userMessages, and I ran some tests locally and verified it's working for me.

dwnoble avatar Oct 08 '24 22:10 dwnoble

This PR looks good to merge. UN updated the site on their end to migrate from userMessage to userMessages, and I ran some tests locally and verified it's working for me.

Thank you for checking, can you approve this PR then if this looks safe?

(I have updated the NL Feedback BQ query to look at userMessages instead of userMessage as well)

chejennifer avatar Oct 09 '24 22:10 chejennifer