wrangling-genomics icon indicating copy to clipboard operation
wrangling-genomics copied to clipboard

Step 3: Filter and report the incorrect directory in hightlight section

Open Hanson19 opened this issue 2 years ago • 1 comments

In step 3 of Variant calling in the section called filtering beginning at line 265 on the github script, where we compare the quality of the of the variants called before and after filtering, the directory name is wrong when running the unfiltered variants. Line 274 currently has /bcf/ instead /vcf/.

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

Hanson19 avatar Jan 09 '24 00:01 Hanson19

:ok: Pre-flight checks passed :smiley:

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

github-actions[bot] avatar Jan 09 '24 00:01 github-actions[bot]

Thank you @Hanson19 for this PR. This is indeed an error in the materials and caused some confusion at my recent workshop as well. I'll go ahead and merge this fix.

ErinBecker avatar Jun 14 '24 19:06 ErinBecker