python-ecology-lesson
python-ecology-lesson copied to clipboard
datacarpentry
small grammatical change
this is a small grammatical change as suggested during the translation to Spanish in https://github.com/Carpentries-ES/python-ecology-lesson-es/pull/30#discussion_r232508766
An alternative could be to say "The SciPy ecosystem..."
I think it sounds better with which:
SciPy is an ecosystem for Python which provides the tools necessary for scientific computing.
One our our Spanish translators thought it was missing a word to make a complete sentence. But, the more I read it, I think it's okay as is. I think it's okay if you want to close without merging @maxim-belkin
We're conveying two messages here: 1. that SciPy is an ecosystem (not just one "thing"). 2. that it provides tools for scientific computing. Then, I don't think that (1) deserves a separate keypoint on its own as this is a rather general statement. So, we remove emphasis on the fact that SciPy is an ecosystem (by not saying "SciPy is an ecosystem) and state it as if this is a known fact.
Nonetheless, I think the right fix is the one you mention in your original message, that is: The SciPy ecosystem. Then, the ecosystem is not really for Python (it's within it), so I think the right change should really be:
The SciPy ecosystem provides tools for scientific computing in Python.
This is more or less the same as what is said on their webpage: https://www.scipy.org/about.html
However, this statement is rather weak. I think we could say:
The SciPy ecosystem provides tools that enable scientific computing in Python.
but this is open for a discussion.
Nice. I really like your last option "The SciPy ecosystem provides tools that enable scientific computing in Python."
I went ahead and inserted that language as a suggestion. Feel free to accept if it looks good, @raynamharris. If it still looks off, we can discuss more.
Hey @raynamharris. I'm just getting back into the swing of things over here - it looks like there's just one outstanding issue to resolve. I made a suggestion; if it looks good, go ahead and accept and I'll merge this.
