R-ecology-lesson
R-ecology-lesson copied to clipboard
datacarpentry
Update 04-visualization-ggplot2.Rmd
To address Plotting with ggplot2 --> geom_boxplot + geom_jitter note #803 Replace geom_boxplot(alpha=0) with geom_boxplot(outlier.shape = NA)
Nice PR! I'd recommend maybe adding an inline comment or some additional text to to the lesson explaining why we added this argument.
Thanks for the tip Sarah! I'm still fairly new at this and made my edit on the patch-1 bratch. Is that correct?
From: Sarah Stevens @.> Sent: Saturday, 6 August 2022 6:11 AM To: datacarpentry/R-ecology-lesson @.> Cc: Erin Graham @.>; Author @.> Subject: Re: [datacarpentry/R-ecology-lesson] Update 04-visualization-ggplot2.Rmd (PR #808)
This message was sent from someone external to JCU. Please do not click links or open attachments unless you recognise the source of this email and know the content is safe.
Nice PR! I'd recommend maybe adding an inline comment or some additional text to to the lesson explaining why we added this argument.
Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdatacarpentry%2FR-ecology-lesson%2Fpull%2F808%23issuecomment-1206818276&data=05%7C01%7Cerin.graham%40jcu.edu.au%7Cb47e055326d54cbfc13508da771ea8be%7C30a8c4e81ecd4f148099f73482a7adc0%7C0%7C0%7C637953270815655165%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=c5HksVaW0uz4YZMmcYl4aihhxxOMuK4CdzJ7s4woxaE%3D&reserved=0, or unsubscribehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA5FFRNQBT2OSYQ6KGMMCG3VXVYOBANCNFSM52LPJI7A&data=05%7C01%7Cerin.graham%40jcu.edu.au%7Cb47e055326d54cbfc13508da771ea8be%7C30a8c4e81ecd4f148099f73482a7adc0%7C0%7C0%7C637953270815655165%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7BN21JaF%2FEekoYN%2F5Sf3C1GekwDxy3ajZ7o83tqpqSs%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.@.>>
Yes @erinmgraham, nice job editing your previous branch used in this PR! I left a small formatting suggestion for the argument text. Looks great!
Suggestion accepted! Thanks for your help 😊
From: Sarah Stevens @.> Sent: Wednesday, 10 August 2022 3:07 AM To: datacarpentry/R-ecology-lesson @.> Cc: Erin Graham @.>; Mention @.> Subject: Re: [datacarpentry/R-ecology-lesson] Update 04-visualization-ggplot2.Rmd (PR #808)
This message was sent from someone external to JCU. Please do not click links or open attachments unless you recognise the source of this email and know the content is safe.
Yes @erinmgrahamhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ferinmgraham&data=05%7C01%7Cerin.graham%40jcu.edu.au%7C6ddb2683a9a3489ec1c808da7a2997b8%7C30a8c4e81ecd4f148099f73482a7adc0%7C0%7C0%7C637956616304825057%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=i5Vfs3SqgAQA4bSvWsc8uZMsk%2BnN1IdcjKKTtgF3F7o%3D&reserved=0, nice job editing your previous branch used in this PR! I left a small formatting suggestion for the argument text. Looks great!
— Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdatacarpentry%2FR-ecology-lesson%2Fpull%2F808%23issuecomment-1209643148&data=05%7C01%7Cerin.graham%40jcu.edu.au%7C6ddb2683a9a3489ec1c808da7a2997b8%7C30a8c4e81ecd4f148099f73482a7adc0%7C0%7C0%7C637956616304825057%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VR%2FTUhkofnmEXtzsNduIR33azm7Ox7axsLs9c9%2BZtQg%3D&reserved=0, or unsubscribehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA5FFRM7BK3WWGXNUHVABHLVYKF3PANCNFSM52LPJI7A&data=05%7C01%7Cerin.graham%40jcu.edu.au%7C6ddb2683a9a3489ec1c808da7a2997b8%7C30a8c4e81ecd4f148099f73482a7adc0%7C0%7C0%7C637956616304825057%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IRqXVQoe5BDjaZgeOYrNp%2FMWTZLqMB2khEt8LjpzWBU%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.@.>>
Thank you for this contribution @erinmgraham. This is a great fix to #803. Unfortunately we have had a gap in Maintainer activity on this lesson. I am filling in to take care of some PRs in preparation for transition to the new lesson infrastructure. I neglected to notice that your PR was an earlier submitted fix for #803 than one that I already accepted and merged https://github.com/datacarpentry/R-ecology-lesson/pull/817. We are currently bringing new Maintainers on for this lesson to improve the contributor experience and ensure useful PRs like yours are merged in a timely manner. Please accept my apologies.
