rdocumentation-2.0 icon indicating copy to clipboard operation
rdocumentation-2.0 copied to clipboard

[CT-3469] Refactor: add autocomplete to navbar, fix redirect

Open ben-brooker opened this issue 2 years ago • 1 comments

Ticket

Making function suggestions redirect straight to topic page instead of global search results page.

Was going to do the same for packages suggestions, however there are some broken links so a risk that the suggestion will link to a "oops, page not found".

Changes

  • OnSearch function ensures that the searchbar clears and the autocomplete disappears once a search has been made. (This is has more of a ui effect on the navbar search as the autocomplete would cover search results otherwise).

  • I have also wrapped autosuggestion text to ensure there is no overflow.

  • I have changed the function redirect to point to specific topic pages and placed in a switch statement.

Pictures

Before (Desktop): Screenshot 2022-07-12 at 16 02 31

After (Desktop): Screenshot 2022-07-12 at 16 06 11

Before (Mobile): Screenshot 2022-07-12 at 16 03 38

After (Mobile): Screenshot 2022-07-12 at 16 03 26

ben-brooker avatar Jul 11 '22 17:07 ben-brooker

Here I think we should remove this, and just pick the 5 items with the highest score that start with what the user entered: https://github.com/datacamp/rdocumentation-2.0/blob/bd0936d18661797a609c866984599d36f30ea89f/components/Autocomplete.tsx#L44-L45

So something similar to this:

     const relevantPackages = packages?.sort((pA, pB) => pB.score-pA.score)
                             ?.filter(p => p.toLowerCase().startsWith(query.toLowerCase()))
                             ?.slice(0, 5);

ztsorojev avatar Jul 12 '22 17:07 ztsorojev