helm-diff icon indicating copy to clipboard operation
helm-diff copied to clipboard

Don't output help on `helm plugin install`

Open z0rc opened this issue 2 months ago • 3 comments

I'm installing helm-diff as part of CI pipeline. Every time plugin installation outputs help page.

I found this unwelcome, as in CI pipeline context this output is effectively a noise. Also it isn't possible to properly silence it. I can do helm plugin install ... >/dev/null, but this will also omit output from helm itself, which is actually valuable.

z0rc avatar Apr 30 '24 11:04 z0rc

PR is welcome

yxxhero avatar Apr 30 '24 11:04 yxxhero

@yxxhero I can just remove https://github.com/databus23/helm-diff/blob/master/install-binary.sh#L146-L152 and https://github.com/databus23/helm-diff/blob/master/install-binary.sh#L166, right? Or do you expect something else?

z0rc avatar Apr 30 '24 12:04 z0rc

@mumoshu @databus23 WDYT?

yxxhero avatar May 05 '24 23:05 yxxhero

@z0rc PR is welcome.

yxxhero avatar May 25 '24 01:05 yxxhero