helm diff upgrade output adding trailing ':'

[chrisblatt]

This plugin has been very helpful and a nice addition to our workflow. I noticed an small inconsistency today when testing some local dev manually and wanted to see if it was a bug or if I was doing something incorrect.

Version of plugin: 3.6.0

Scenario:

I recently broke up my values file from this:

image: thanosio/thanos:v0.28.1

to this:

image:
  repository: thanosio/thanos
  tag: v0.28.1

This made it so I changed my deployment from this:

image: {{ .Values.image }}

to this:

image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"

After making this change I anticipated the only change helm diff might see is the added '"' but this is the output I got:

-     image: thanosio/thanos:v0.28.1
+    image: "thanosio/thanos:v0.28.1:"

Notice the trailing ':', but if I run a helm template on the chart I see this:

"thanosio/thanos:v0.28.1"

So to me seems like parsing error somewhere, also I noticed if I but this in the deployment file:

image: "{{ .Values.image.repository }}{{ .Values.image.tag }}"

helm diff shows only changes being this:

-    image: thanosio/thanos:v0.28.1
+   image: "thanosio/thanos:v0.28.1"

but helm template shows this:

image: "thanosio/thanosv0.28.1"

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[yxxhero]

@chrisblatt try to use the latest verison.