tempo icon indicating copy to clipboard operation
tempo copied to clipboard

Published 20 hours ago • verified publisher icon databrickslabs

CI/CD overhaul

Open jtisbell4 opened this issue 10 months ago • 4 comments

Major changes to test and build infrastructure, predominantly related to tox:

  • tox environments correctly configured
  • GH actions simplified/refactored to exclusively use tox
  • Officially dropped support for DBR < 11.3
  • Moved DBR-specific requirements into python/tests/requirements
  • Made SparkSession initialization dynamic in test class setup

A few minor changes in python/tempo:

  • Fixed if statement in TSDF.withRangeStats
  • Removed event_time column assumption and made Z-ORDER attempt contingent on optimizationCols in io.write

jtisbell4 avatar Apr 28 '24 20:04 jtisbell4

ValueError: Incorrect data format, should be YYYY-MM-DD HH:MM:SS[.nnnnnnnn]

Looks like some tests are still failing with this error. Did the fix for this get merged into master?

R7L208 avatar May 14 '24 15:05 R7L208

ValueError: Incorrect data format, should be YYYY-MM-DD HH:MM:SS[.nnnnnnnn]

Looks like some tests are still failing with this error. Did the fix for this get merged into master?

@R7L208 Not yet. @tnixon and I had a conversation about this issue on Slack. Not sure what he wants to do to fix it.

jtisbell4 avatar May 14 '24 16:05 jtisbell4

ValueError: Incorrect data format, should be YYYY-MM-DD HH:MM:SS[.nnnnnnnn] Looks like some tests are still failing with this error. Did the fix for this get merged into master?

@R7L208 Not yet. @tnixon and I had a conversation about this issue on Slack. Not sure what he wants to do to fix it.

I was working on a fix for this but got distracted. Let me see how quick I can push that change.

tnixon avatar May 14 '24 17:05 tnixon

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot] avatar May 22 '24 19:05 github-advanced-security[bot]