tempo icon indicating copy to clipboard operation
tempo copied to clipboard

asofJoin() requires name of timpestamp column names to match

Open ghormann opened this issue 1 year ago • 1 comments

When trying to use asofJoin() on two TSDF records with different time series column names an exception is raised. I'm not sure if this is a considered a bug or a feature, but given that TSDF knows the column name of each TSDF object, it seems like it should be smart enough to execute the join.

Example

  • tsdf_state has time column 'ts'
  • tsdf_validate has time column 'EndTime'
  • Running asofJoin() results in an error as it is using EndTime on tsdf_state

image

Workaround

If I make sure the time column is the same for both TSDF records it appears to work as expected. (Here column 'ts' is created as a copy of EndTime before creating tsdf_validate).

image

ghormann avatar Mar 03 '24 23:03 ghormann

Thanks for raising this to us, @ghormann - definitely a frustrating issue. I believe this should be fixed in the upcoming v0.2 version, but we'll be sure to double check. Maybe it makes sense to get a quick fix in here before that comes out.

tnixon avatar Mar 07 '24 18:03 tnixon