overwatch icon indicating copy to clipboard operation
overwatch copied to clipboard

Change dbname declaration in spark.catalog.exists

Open souravbaner-da opened this issue 2 years ago • 6 comments

Close #858

souravbaner-da avatar Apr 03 '23 09:04 souravbaner-da

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@souravbaner-da -- test is failing

https://github.com/databrickslabs/overwatch/blob/5337cadd510f596b03914ea48066db0f5df21641/src/test/scala/com/databricks/labs/overwatch/pipeline/InitializeTest.scala#L39-L53

https://github.com/databrickslabs/overwatch/blob/5337cadd510f596b03914ea48066db0f5df21641/src/test/scala/com/databricks/labs/overwatch/pipeline/InitializeTest.scala#L239-L247

GeekSheikh avatar Apr 05 '23 17:04 GeekSheikh

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 05 '23 21:04 sonarqubecloud[bot]

Currently this issue will be on hold. As the suggested solution depend on spark version. Specifically from spark version 3.3.0 the solution is working fine and for all other version the solution is failing. Only solution for this is to check spark version during the check of database exist and build our solution depend on the spark version. May be look into it in future release.

For now in overwatch public doc we will mention that database name in config should not contain any special character. Corresponding PR for the documentation is https://github.com/databrickslabs/overwatch/pull/875

souravbaner-da avatar Apr 11 '23 11:04 souravbaner-da

Currently this PR is on hold. Will start working on this after we are done with below issue #858

souravbaner-da avatar May 16 '23 06:05 souravbaner-da

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant