dbldatagen icon indicating copy to clipboard operation
dbldatagen copied to clipboard

Feature streaming enhancments

Open ronanstokes-db opened this issue 3 years ago • 10 comments

Proposed changes

Added support for rate-micro-batch source Added ageLimit option for rate source More extensive testing for streaming scenarios

Note: still work in progress - PR opened to validate unit tests on GitHub build runner

Types of changes

What types of changes does your code introduce to dbldatagen? Put an x in the boxes that apply

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Change to tutorials, tests or examples
  • [x] Non code change (readme, images or other non-code assets)
  • [x] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] Lint and unit tests pass locally with my changes
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added necessary documentation (if appropriate)
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [x] Submission does not reduce code coverage numbers
  • [ ] Submission does not increase alerts or messages from LGTM

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

ronanstokes-db avatar Oct 20 '22 17:10 ronanstokes-db

This pull request introduces 1 alert when merging 51adf3968b392662b8dd52054849c8d6a9c56f15 into 23a83f5ef768a55f9da8827876f763caafdb672b - view on LGTM.com

new alerts:

  • 1 for Unused local variable

lgtm-com[bot] avatar Oct 20 '22 17:10 lgtm-com[bot]

This pull request introduces 1 alert when merging 46f84062f72caeeb2e383eba6d05ee2cc60578e9 into 83c5ed4e3b47d8e83fab11072e0b5b869c84f80d - view on LGTM.com

new alerts:

  • 1 for Unused local variable

lgtm-com[bot] avatar Oct 21 '22 00:10 lgtm-com[bot]

This pull request introduces 1 alert when merging e0f7887f41653245259f5d8b9549068f02a027a1 into d6b1799ecf5bcb3be9ac14d3366454da427f52c1 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

lgtm-com[bot] avatar Oct 25 '22 15:10 lgtm-com[bot]

Need to update test process to test on specific Databricks builds or open source Spark equivalent

ronanstokes-db avatar Oct 28 '22 06:10 ronanstokes-db

This pull request introduces 1 alert when merging 2b3060e9972448d3b93b642d490ac803f2215327 into 109707e9fdec3185688dce5a1d9a7f342cca069d - view on LGTM.com

new alerts:

  • 1 for Unused local variable

lgtm-com[bot] avatar Nov 01 '22 18:11 lgtm-com[bot]

This pull request introduces 1 alert when merging 1b91312d9b5381856f7f6fd65bc1787f107d02ae into 981a5a4b07b0ee981c5b77ee908c855c47f84bb2 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 28 '22 21:11 lgtm-com[bot]

Note v0.3.1 is the release for the target version to incorporate these changes.

ronanstokes-db avatar Dec 01 '22 20:12 ronanstokes-db

Codecov Report

Merging #127 (ab5908a) into master (bc80ef3) will decrease coverage by 1.73%. The diff coverage is 85.49%.

:exclamation: Current head ab5908a differs from pull request most recent head 041b3dc. Consider uploading reports for the commit 041b3dc to get more accurate results

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   91.97%   90.25%   -1.73%     
==========================================
  Files          23       23              
  Lines        2680     2637      -43     
  Branches      452      438      -14     
==========================================
- Hits         2465     2380      -85     
- Misses        128      165      +37     
- Partials       87       92       +5     
Impacted Files Coverage Δ
dbldatagen/data_generator.py 84.79% <82.00%> (-0.32%) :arrow_down:
dbldatagen/enhanced_event_time.py 96.77% <96.77%> (ø)

... and 12 files with indirect coverage changes

codecov[bot] avatar Mar 07 '23 15:03 codecov[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 27 '23 20:11 CLAassistant