Feature id fixes

[ronanstokes-db]

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers. If it fixes a bug or resolves a feature request, please provide a link to that issue.

Types of changes

What types of changes does your code introduce to dbx? Put an x in the boxes that apply

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Change to tutorials, tests or examples
• [ ] Non code change (readme, images or other non-code assets)
• [x] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• [x] Lint and unit tests pass locally with my changes
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] I have added necessary documentation (if appropriate)
• [ ] Any dependent changes have been merged and published in downstream modules
• [x] Submission does not reduce code coverage numbers
• [x] Submission does not increase alerts or messages from LGTM

Further comments

Fixes collisions between system 'id' column and user explicitly adding id column by offering parameter to DataGenerator constructor allowing specification of an alternate id column

[codecov[bot]]

Codecov Report

Merging #114 (7bc9b37) into master (c1ee9cb) will increase coverage by 0.15%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   89.49%   89.64%   +0.15%     
==========================================
  Files          22       22              
  Lines        2332     2347      +15     
  Branches      375      377       +2     
==========================================
+ Hits         2087     2104      +17     
+ Misses        160      159       -1     
+ Partials       85       84       -1     

Impacted Files	Coverage Δ
dbldatagen/column_generation_spec.py	87.33% <100.00%> (ø)
dbldatagen/data_generator.py	84.03% <100.00%> (+0.80%)	:arrow_up:
dbldatagen/datagen_constants.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[renardeinside]

@ronanstokes-db seems like you've copied the ISSUE_TEMPLATE without changing it from dbx 😄 :

What types of changes does your code introduce to dbx?

(ronan: fixed in separate checkin)

[ronanstokes-db]

v0.3.1 is target release version for this feature