terraform-provider-databricks [WIP] Add `databricks_mws_network_connectivity

[WIP] Add `databricks_mws_network_connectivity_config` data source

Open 840 opened this issue 1 year ago • 3 comments

trafficstars

Changes

Add databricks_mws_network_connectivity_config data source

Resolves #3614

Tests

[x] make test run locally
[x] relevant change in docs/ folder
[x] covered with integration tests in internal/acceptance
[ ] relevant acceptance tests are passing
[x] using Go SDK

Jun 11 '24 14:06 840

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.62%. Comparing base (f1cebcb) to head (caacadc). Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
+ Coverage   81.59%   81.62%   +0.02%     
==========================================
  Files         196      197       +1     
  Lines       19739    19764      +25     
==========================================
+ Hits        16107    16132      +25     
  Misses       2672     2672              
  Partials      960      960

Files	Coverage Δ
mws/data_mws_network_connectivity_config.go	`100.00% <100.00%> (ø)`
provider/provider.go	`93.99% <100.00%> (+0.02%)`	:arrow_up:

Jun 11 '24 14:06 codecov-commenter

I have trouble running the acceptance test on an account-level locally. Will reply back when I'm able to make it work

Jun 11 '24 16:06 840

The OpenAPI spec for NetworkConnectivityConfiguration is out-of-date. I have to wait until it is fixed before I can continue. I have already reported this to the respective team.

Jun 21 '24 13:06 840

I noticed an issue with regions for acceptance tests; those are different depending on the cloud. Will look into it.

Nov 15 '24 10:11 840

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger: go/deco-tests-run/terraform

Inputs: