terraform-provider-databricks icon indicating copy to clipboard operation
terraform-provider-databricks copied to clipboard

Add support for ESC (Enhanced Compliance and Security) settings

Open harshshah-db opened this issue 1 year ago • 1 comments

Changes

Added enhanced_security_monitoring settings. Will add compliance_security_profile in a follow up PR.

Tests

  • [x] make test run locally
  • [x] relevant change in docs/ folder
  • [ ] covered with integration tests in internal/acceptance
  • [ ] relevant acceptance tests are passing
  • [x] using Go SDK

harshshah-db avatar May 10 '24 05:05 harshshah-db

Codecov Report

Attention: Patch coverage is 98.46154% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.70%. Comparing base (31df20c) to head (8fe8ad3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3563      +/-   ##
==========================================
+ Coverage   82.64%   82.70%   +0.05%     
==========================================
  Files         184      186       +2     
  Lines       19039    19101      +62     
==========================================
+ Hits        15735    15797      +62     
  Misses       2384     2384              
  Partials      920      920              
Files Coverage Δ
settings/all_settings.go 100.00% <100.00%> (ø)
...tings/resource_automatic_cluster_update_setting.go 100.00% <100.00%> (ø)
...s/resource_enhanced_security_monitoring_setting.go 100.00% <100.00%> (ø)
settings/generic_setting.go 41.45% <0.00%> (ø)

codecov-commenter avatar May 10 '24 05:05 codecov-commenter

jenkins merge

harshshah-db avatar May 15 '24 17:05 harshshah-db

@harshshah-db there is no Jenkins here ;-)

alexott avatar May 15 '24 17:05 alexott

@harshshah-db there is no Jenkins here ;-)

yeah just figured that :) How do I add it to the merge queue?

harshshah-db avatar May 15 '24 17:05 harshshah-db