terraform-provider-databricks
terraform-provider-databricks copied to clipboard
Fixed Issue: The field 'node_type_id' cannot be supplied when an instance pool ID is provided
Changes
We earlier used to have only one spec that we used to pass for all the requests, after migration since we use different requests, we need to modify the fields for them as well.
Fixes: https://github.com/databricks/terraform-provider-databricks/issues/3533
Tests
Updated unit tests and integration test to check for this. Also, manually used this change (local binary) to run tf apply over test infra.
This wasn't caught in unit or integration test so there is a gap in our tests. The above step in integration test updates autotermination_minutes and this should repro this issue and changes should fix it.
Integration test passes on PR and fail on main.
- [x]
make testrun locally - [ ] relevant change in
docs/folder - [x] covered with integration tests in
internal/acceptance - [x] relevant acceptance tests are passing
- [x] using Go SDK
Codecov Report
Attention: Patch coverage is 70.27027% with 22 lines in your changes are missing coverage. Please review.
Project coverage is 82.55%. Comparing base (
76a2d61) to head (da26cf4).
Additional details and impacted files
@@ Coverage Diff @@
## main #3549 +/- ##
==========================================
- Coverage 82.64% 82.55% -0.10%
==========================================
Files 184 184
Lines 19041 19077 +36
==========================================
+ Hits 15737 15749 +12
- Misses 2384 2405 +21
- Partials 920 923 +3
| Files | Coverage Δ | |
|---|---|---|
| clusters/resource_cluster.go | 77.42% <70.27%> (-3.69%) |
:arrow_down: |