terraform-provider-databricks icon indicating copy to clipboard operation
terraform-provider-databricks copied to clipboard

Add support for setting table tags via terraform

Open yash-asana opened this issue 1 year ago • 13 comments

Changes

Add support for setting table tags via terraform.

https://docs.databricks.com/en/data-governance/unity-catalog/tags.html

Tests

  • [x] make test run locally
  • [x] relevant change in docs/ folder
  • [x] covered with integration tests in internal/acceptance Not seeing these for similar fields e.g. properties/options
  • [x] relevant acceptance tests are passing
  • [ ] using Go SDK
  • [x] Manual testing Able to create tags on table as well as create new ones, update values, and delete others

yash-asana avatar Feb 15 '24 23:02 yash-asana

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a644c6a) 83.76% compared to head (5a63027) 83.52%. Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
- Coverage   83.76%   83.52%   -0.24%     
==========================================
  Files         170      171       +1     
  Lines       15301    15457     +156     
==========================================
+ Hits        12817    12911      +94     
- Misses       1732     1781      +49     
- Partials      752      765      +13     
Files Coverage Δ
catalog/resource_sql_table.go 84.55% <45.45%> (-4.02%) :arrow_down:

... and 14 files with indirect coverage changes

codecov-commenter avatar Feb 16 '24 09:02 codecov-commenter

Please run make fmt on the code...

alexott avatar Feb 16 '24 09:02 alexott

@alexott Is there anything else this PR needs to be ready for review?

yash-asana avatar Mar 04 '24 21:03 yash-asana

@tanmay-db / @alexott This PR has been staged for a while, what can I do to make it reviewable?

yash-asana avatar Apr 03 '24 17:04 yash-asana

@edwardfeng-db Anything I can do to help in the review process?

yash-asana avatar Apr 10 '24 18:04 yash-asana

Is this only for table tags, is there another PR/issue for catalog tags?

nexeck avatar Apr 25 '24 13:04 nexeck