terraform-provider-databricks
terraform-provider-databricks copied to clipboard
Add support for setting table tags via terraform
Changes
Add support for setting table tags via terraform.
https://docs.databricks.com/en/data-governance/unity-catalog/tags.html
Tests
- [x]
make testrun locally - [x] relevant change in
docs/folder - [x] covered with integration tests in
internal/acceptanceNot seeing these for similar fields e.g. properties/options - [x] relevant acceptance tests are passing
- [ ] using Go SDK
- [x] Manual testing Able to create tags on table as well as create new ones, update values, and delete others
Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.
Comparison is base (
a644c6a) 83.76% compared to head (5a63027) 83.52%. Report is 10 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3268 +/- ##
==========================================
- Coverage 83.76% 83.52% -0.24%
==========================================
Files 170 171 +1
Lines 15301 15457 +156
==========================================
+ Hits 12817 12911 +94
- Misses 1732 1781 +49
- Partials 752 765 +13
| Files | Coverage Δ | |
|---|---|---|
| catalog/resource_sql_table.go | 84.55% <45.45%> (-4.02%) |
:arrow_down: |
Please run make fmt on the code...
@alexott Is there anything else this PR needs to be ready for review?
@tanmay-db / @alexott This PR has been staged for a while, what can I do to make it reviewable?
@edwardfeng-db Anything I can do to help in the review process?
Is this only for table tags, is there another PR/issue for catalog tags?