terraform-provider-databricks icon indicating copy to clipboard operation
terraform-provider-databricks copied to clipboard

Add `databricks_file` resource

Open hectorcast-db opened this issue 1 year ago • 3 comments

Changes

Add databricks_file resource

Tests

  • [X] make test run locally
  • [X] relevant change in docs/ folder
  • [X] covered with integration tests in internal/acceptance
  • [ ] (running) relevant acceptance tests are passing
  • [X] using Go SDK

hectorcast-db avatar Feb 15 '24 14:02 hectorcast-db

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (d0a7413) 83.72% compared to head (b0ff36c) 83.64%.

:exclamation: Current head b0ff36c differs from pull request most recent head 817501d. Consider uploading reports for the commit 817501d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3265      +/-   ##
==========================================
- Coverage   83.72%   83.64%   -0.09%     
==========================================
  Files         173      174       +1     
  Lines       15757    15851      +94     
==========================================
+ Hits        13193    13259      +66     
- Misses       1789     1805      +16     
- Partials      775      787      +12     
Files Coverage Δ
provider/provider.go 94.62% <100.00%> (+0.02%) :arrow_up:
workspace/file_resource.go 91.22% <0.00%> (-5.07%) :arrow_down:
storage/resource_file.go 72.41% <72.41%> (ø)

... and 1 file with indirect coverage changes

codecov-commenter avatar Feb 15 '24 14:02 codecov-commenter

I'm not sure about the name - it's too generic if it allows to work only with Volumes... Or do we plan to use the same resource for all file types - DBFS, WSFS, etc.? But documentation mentions only Volumes, and if it's true, then it should be called like databricks_volume_file, not generic databricks_file

alexott avatar Feb 15 '24 15:02 alexott

@alexott For now, it only supports Volumes, but they plan to expand to other resources. We are discussing possible changes to the docs.

hectorcast-db avatar Feb 15 '24 15:02 hectorcast-db