terraform-provider-databricks
terraform-provider-databricks copied to clipboard
PLAT-99110: Added terraform support for restrict ws admins setting
Changes
Followed instructions in https://docs.google.com/document/d/1tXZCuZ1Vl6F3Syu23jQOaxguavTB3Mz_RugEafxdhik/edit to add terraform support for restrict workspace admins setting.
Tests
- [x]
make testrun locally - [x] relevant change in
docs/folder - [x] covered with integration tests in
internal/acceptance - [x] relevant acceptance tests are passing
- [x] using Go SDK
Can we add the unit test and integration tests (if possible)?
We also need docs
Yep, I am adding docs, unit tests and integration tests. Will ping when it is ready for review.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
bc5dcb5) 83.59% compared to head (2f67d4f) 83.60%.
Additional details and impacted files
@@ Coverage Diff @@
## main #3243 +/- ##
==========================================
+ Coverage 83.59% 83.60% +0.01%
==========================================
Files 171 172 +1
Lines 15444 15466 +22
==========================================
+ Hits 12910 12930 +20
- Misses 1771 1772 +1
- Partials 763 764 +1
| Files | Coverage Δ | |
|---|---|---|
| settings/all_settings.go | 100.00% <100.00%> (ø) |
|
| ...ings/resource_restrict_workspace_admins_setting.go | 100.00% <100.00%> (ø) |
@alexott @hectorcast-db the PR is ready for review.