terraform-provider-databricks icon indicating copy to clipboard operation
terraform-provider-databricks copied to clipboard

PLAT-99110: Added terraform support for restrict ws admins setting

Open gauthamsunjay opened this issue 1 year ago • 5 comments
trafficstars

Changes

Followed instructions in https://docs.google.com/document/d/1tXZCuZ1Vl6F3Syu23jQOaxguavTB3Mz_RugEafxdhik/edit to add terraform support for restrict workspace admins setting.

Tests

  • [x] make test run locally
  • [x] relevant change in docs/ folder
  • [x] covered with integration tests in internal/acceptance
  • [x] relevant acceptance tests are passing
  • [x] using Go SDK

gauthamsunjay avatar Feb 09 '24 20:02 gauthamsunjay

Can we add the unit test and integration tests (if possible)?

alexott avatar Feb 15 '24 19:02 alexott

We also need docs

alexott avatar Feb 15 '24 19:02 alexott

Yep, I am adding docs, unit tests and integration tests. Will ping when it is ready for review.

gauthamsunjay avatar Feb 15 '24 19:02 gauthamsunjay

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bc5dcb5) 83.59% compared to head (2f67d4f) 83.60%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3243      +/-   ##
==========================================
+ Coverage   83.59%   83.60%   +0.01%     
==========================================
  Files         171      172       +1     
  Lines       15444    15466      +22     
==========================================
+ Hits        12910    12930      +20     
- Misses       1771     1772       +1     
- Partials      763      764       +1     
Files Coverage Δ
settings/all_settings.go 100.00% <100.00%> (ø)
...ings/resource_restrict_workspace_admins_setting.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

codecov-commenter avatar Feb 15 '24 23:02 codecov-commenter

@alexott @hectorcast-db the PR is ready for review.

gauthamsunjay avatar Feb 16 '24 01:02 gauthamsunjay