terraform-provider-databricks icon indicating copy to clipboard operation
terraform-provider-databricks copied to clipboard

[Feature] Add support for Databricks Account Console IP Access Lists

Open nkvuong opened this issue 1 year ago • 6 comments
trafficstars

Changes

  • Add support for databricks_ip_access_list at account-level
  • Refactor databricks_ip_access_list tests to use Mock

Tests

  • [x] make test run locally
  • [x] relevant change in docs/ folder
  • [x] covered with integration tests in internal/acceptance
  • [ ] relevant acceptance tests are passing
  • [x] using Go SDK

nkvuong avatar Feb 06 '24 12:02 nkvuong

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (662a0bd) 83.60% compared to head (bed1350) 83.61%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3221      +/-   ##
==========================================
+ Coverage   83.60%   83.61%   +0.01%     
==========================================
  Files         169      169              
  Lines       15094    15132      +38     
==========================================
+ Hits        12619    12653      +34     
- Misses       1735     1739       +4     
  Partials      740      740              
Files Coverage Δ
access/resource_ip_access_list.go 87.50% <84.12%> (+6.54%) :arrow_up:

... and 1 file with indirect coverage changes

codecov-commenter avatar Feb 06 '24 12:02 codecov-commenter