terraform-provider-databricks icon indicating copy to clipboard operation
terraform-provider-databricks copied to clipboard

Added `filter` block to `databricks_instance_profiles` data source

Open ehab-eb opened this issue 1 year ago • 1 comments
trafficstars

Changes

This PR adds filtering capabilities to the databricks_instance_profiles data source. A new optional block filter is introduced that exposes two arguments:

  1. name: This takes the name of the instance profile attribute to filter on
  2. pattern: This takes a regex pattern to use for filtering based on the field specified in the name argument

Only one filter block can be specified.

Tests

  • [x] make test run locally
  • [x] relevant change in docs/ folder
  • [x] covered with integration tests in internal/acceptance
  • [ ] relevant acceptance tests are passing
  • [x] using Go SDK

ehab-eb avatar Dec 04 '23 11:12 ehab-eb

Codecov Report

Merging #2988 (b1c0f85) into master (2359eb0) will increase coverage by 0.03%. The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2988      +/-   ##
==========================================
+ Coverage   84.14%   84.17%   +0.03%     
==========================================
  Files         159      159              
  Lines       13897    13912      +15     
==========================================
+ Hits        11694    11711      +17     
+ Misses       1534     1533       -1     
+ Partials      669      668       -1     
Files Coverage Δ
aws/data_instance_profiles.go 94.28% <100.00%> (+4.28%) :arrow_up:

... and 1 file with indirect coverage changes

codecov-commenter avatar Dec 15 '23 14:12 codecov-commenter