terraform-provider-databricks
terraform-provider-databricks copied to clipboard
Feature/add reuse key for cluster volumes to cmk
- Added new field to Terraform resource
mws_customer_managed_keyto stop the key from being used to encrypt cluster volumes - The new field defaults to
trueto preserve the existing behaviour of this resource so people don't have to update their code to include the new field if they don't want to use it - Added test to check that setting the field to
falsereturns the correct response
Codecov Report
Merging #1218 (8071c60) into master (16c6a22) will decrease coverage by
0.09%. The diff coverage isn/a.
:exclamation: Current head 8071c60 differs from pull request most recent head 3fc55b5. Consider uploading reports for the commit 3fc55b5 to get more accurate results
@@ Coverage Diff @@
## master #1218 +/- ##
==========================================
- Coverage 90.80% 90.70% -0.10%
==========================================
Files 117 117
Lines 9724 9749 +25
==========================================
+ Hits 8830 8843 +13
- Misses 528 538 +10
- Partials 366 368 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| mws/resource_customer_managed_key.go | 92.10% <ø> (ø) |
|
| common/gcp.go | 71.83% <0.00%> (-11.51%) |
:arrow_down: |
| common/client.go | 99.15% <0.00%> (+<0.01%) |
:arrow_up: |
When I have tested this in a Terraform project when it is set to true it is causing the field to be added to the resource which causes the resource to be rebuilt and in turn it requires the Databricks workspace to be rebuilt. Can you offer any assistance on how to achieve this addition of not having the customer managed key be used to encrypt cluster volumes without introducing breaking changes?
@johnc1996 Please add state upgrader, so that workspace is not rebuilt.
@johnc1996 Please add state upgrader, so that workspace is not rebuilt.
PR is out of date. please create a new one.