terraform-provider-databricks icon indicating copy to clipboard operation
terraform-provider-databricks copied to clipboard

Feature/add reuse key for cluster volumes to cmk

Open johnc1996 opened this issue 3 years ago • 4 comments
trafficstars

  • Added new field to Terraform resource mws_customer_managed_key to stop the key from being used to encrypt cluster volumes
  • The new field defaults to true to preserve the existing behaviour of this resource so people don't have to update their code to include the new field if they don't want to use it
  • Added test to check that setting the field to false returns the correct response

johnc1996 avatar Mar 24 '22 15:03 johnc1996

Codecov Report

Merging #1218 (8071c60) into master (16c6a22) will decrease coverage by 0.09%. The diff coverage is n/a.

:exclamation: Current head 8071c60 differs from pull request most recent head 3fc55b5. Consider uploading reports for the commit 3fc55b5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1218      +/-   ##
==========================================
- Coverage   90.80%   90.70%   -0.10%     
==========================================
  Files         117      117              
  Lines        9724     9749      +25     
==========================================
+ Hits         8830     8843      +13     
- Misses        528      538      +10     
- Partials      366      368       +2     
Impacted Files Coverage Δ
mws/resource_customer_managed_key.go 92.10% <ø> (ø)
common/gcp.go 71.83% <0.00%> (-11.51%) :arrow_down:
common/client.go 99.15% <0.00%> (+<0.01%) :arrow_up:

codecov[bot] avatar Mar 24 '22 20:03 codecov[bot]

When I have tested this in a Terraform project when it is set to true it is causing the field to be added to the resource which causes the resource to be rebuilt and in turn it requires the Databricks workspace to be rebuilt. Can you offer any assistance on how to achieve this addition of not having the customer managed key be used to encrypt cluster volumes without introducing breaking changes?

johnc1996 avatar Mar 31 '22 11:03 johnc1996

@johnc1996 Please add state upgrader, so that workspace is not rebuilt.

nfx avatar Apr 30 '22 12:04 nfx

@johnc1996 Please add state upgrader, so that workspace is not rebuilt.

nfx avatar May 30 '22 10:05 nfx

PR is out of date. please create a new one.

nfx avatar Mar 02 '23 10:03 nfx