dbt-databricks icon indicating copy to clipboard operation
dbt-databricks copied to clipboard

Dev Container environment

Open ghjklw opened this issue 1 year ago • 4 comments

Description

To facilitate working on this project, I began setting up a Dev Container / GitHub codespace environment.

This is a fairly basic setup at this point, but I believe it might be useful to others, and a good way to lower the threshold to contributing to the adapter.

Potential for improvement:

  • I struggled a bit to write a script to automate the setup of a databricks_demo project as described in CONTRIBUTING.md because the dbt-databricks adapter doesn't seem to be recognized by dbt when installed in editable mode.
  • The unit tests should work out of the box, but I haven't been able to test setting up the integration tests.
  • There is potential to implement a few more reocmmendations/best practices for environment configuration and setup to make the experience even smoother (for example install a couple of tools like databricks CLI or argcomplete, add relevant VS Code extensions or settings), but these might be better to handle as follow-up PR in order to discuss their relevance individually.

Could you please let me know if this is something you're interesting in before I put any more effort in it.

Checklist

  • [x] I have run this code in development and it appears to resolve the stated issue
  • [ ] This PR includes tests, or tests are not required/relevant for this PR
  • [ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

ghjklw avatar Dec 17 '24 22:12 ghjklw

Awesome! This is a cool effort, and will review in the next day or so.

benc-db avatar Dec 17 '24 22:12 benc-db

I really need to update the contributing doc, but thank you for taking a pass at it :).

benc-db avatar Dec 17 '24 22:12 benc-db

Just add an entry in the Changelog (1.9.2) when you're ready for me to merge this. You might want to give a pointer to how to connect this up in docs/dbt-databricks-dev.md

benc-db avatar Dec 18 '24 19:12 benc-db

That was long overdue! Agreed with all your comments 👌

ghjklw avatar Mar 08 '25 00:03 ghjklw