databricks-sdk-py icon indicating copy to clipboard operation
databricks-sdk-py copied to clipboard

Remove noisy `azure_workspace_resource_id field not provided` message for non-production Databricks deployments

Open nfx opened this issue 1 year ago • 3 comments

Changes

JWT mismatched claims errors are only happening for dev and staging deployments of Databricks, adding the unnecessary noise to production users. azure_workspace_resource_id is not required for authentication to succeed.

Tests

  • [ ] make test run locally
  • [ ] make fmt applied
  • [ ] relevant integration tests applied

nfx avatar Oct 17 '23 11:10 nfx

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
databricks/sdk/core.py 80.40% <0.00%> (-0.09%) :arrow_down:

:loudspeaker: Thoughts on this report? Let us know!.

codecov-commenter avatar Oct 17 '23 11:10 codecov-commenter

This can also happen if the user has multiple tenants setup in their azure cli. Miles deduplicated the warning message in here: https://github.com/databricks/databricks-sdk-py/pull/410/files

hectorcast-db avatar Oct 23 '23 07:10 hectorcast-db

This warning message is intentional and is designed to help out users who haven't specified the azure resource ID for workspace they are logging into when using Azure CLI auth. If you specify the azure resource ID in your configuration, that warning message will disappear.

mgyucht avatar Oct 24 '23 08:10 mgyucht