databricks-sdk-py icon indicating copy to clipboard operation
databricks-sdk-py copied to clipboard

Added `w.config.account_host` to get the relevant account host from a workspace client

Open nfx opened this issue 1 year ago • 6 comments

Changes

This simplifies downstream integration testing as well as configuration

Tests

  • [ ] make test run locally
  • [ ] make fmt applied
  • [ ] relevant integration tests applied

nfx avatar Oct 06 '23 18:10 nfx

Codecov Report

All modified lines are covered by tests :white_check_mark:

Files Coverage Δ
databricks/sdk/azure.py 100.00% <100.00%> (ø)
databricks/sdk/core.py 80.69% <100.00%> (+0.32%) :arrow_up:

:loudspeaker: Thoughts on this report? Let us know!.

codecov-commenter avatar Oct 06 '23 18:10 codecov-commenter

One nit to make this work for dev/staging & label as experimental, but otherwise this seems reasonable to me if it unblocks you/customers.

mgyucht avatar Oct 12 '23 13:10 mgyucht

all the info here is fine to be public ( and already public)

hamza-db avatar Nov 08 '23 20:11 hamza-db

this needs a bit more adjustments to work

nfx avatar Nov 09 '23 11:11 nfx

Are similar PRs for the other SDKs tracked some place?

pietern avatar Nov 09 '23 12:11 pietern

@pietern i'll have one for GoLang the following week - once i figure out the way to have it friendly for unit tests, need the same thing for two projects

nfx avatar Nov 10 '23 16:11 nfx