databricks-cli icon indicating copy to clipboard operation
databricks-cli copied to clipboard

updated Dockerfile so tests would pass and image would build

Open jeffreybreen opened this issue 6 years ago • 4 comments

To follow up on Issue 166, the current Dockerfile fails to build as the tests do not pass.

I have made the following changes and it now builds (and runs the CLI) successfully:

  • The packages listed in tox-requirements.txt are required for the tests to run (and pass), so the Dockerfile now installs them
    • I bumped the versions of several of these packages to resolve errors regarding pytest-django and pyflakes
    • there is still a warning that prospector requires a newer version of pylint, but all tests are now passing
  • click and tabulate packages seem to be required by the main codebase, so I added them to dev-requirements.txt so they are installed (and stick around)
  • In order to satisfy pyroma, the Apache license is now listed in the classifiers in setup.py

To save space in the image:

  • All pip install commands now have the --no-cache-dir option
  • All packages listed in tox-requirements.txt are now removed after the tests have been run

jeffreybreen avatar Aug 15 '18 01:08 jeffreybreen

Codecov Report

Merging #167 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          30       30           
  Lines        1938     1938           
=======================================
  Hits         1616     1616           
  Misses        322      322
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8637478...3f056a7. Read the comment docs.

codecov-io avatar Aug 15 '18 01:08 codecov-io

Any idea when this will be merged?

hagridaaron avatar Mar 08 '19 16:03 hagridaaron

@hagridaaron, as it is, this PR isn't ready to merge (merge conflicts and changes to workspace/api.py. Is your goal just to make the docker image build?

andrewmchen avatar Mar 08 '19 17:03 andrewmchen

On this fork I get:

executor failed running [/bin/sh -c pip install --upgrade --no-cache-dir pip &&       pip install --no-cache-dir             -r dev-requirements.txt            -r tox-requirements.txt &&     pip list &&     ./lint.sh &&     pip install --no-cache-dir . &&     pytest tests  &&     pip uninstall -y         -r tox-requirements.txt]: exit code: 1

rvvincelli avatar Oct 28 '21 17:10 rvvincelli