cli icon indicating copy to clipboard operation
cli copied to clipboard

Normalize output paths when downloading files

Open pietern opened this issue 6 months ago β€’ 2 comments

Changes

The "bundle generate" suite of commands generate bundle configuration and download relevant files from the workspace to the local file tree. Some paths that are valid in the Databricks workspace are not valid on Windows. This change normalizes path components to always be Windows-compatible.

Why

Fix the class of issues demonstrated by #2528.

Tests

  • New unit tests.
  • Manually confirmed that running "bundle generate" for a pipeline with a source file that includes incompatible characters now works as expected on Windows.

pietern avatar Jun 19 '25 10:06 pietern

This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled.

github-actions[bot] avatar Aug 23 '25 00:08 github-actions[bot]

Run: 18460977825

Env πŸ”„β€‹flaky βœ…β€‹pass πŸ™ˆβ€‹skip
βœ…β€‹ aws linux 322 545
βœ…β€‹ aws windows 323 544
βœ…β€‹ aws-ucws linux 438 441
πŸ”„β€‹ aws-ucws windows 2 437 440
βœ…β€‹ azure linux 322 544
βœ…β€‹ azure windows 323 543
βœ…β€‹ azure-ucws linux 438 440
βœ…β€‹ azure-ucws windows 439 439
πŸ”„β€‹ gcp linux 3 318 546
βœ…β€‹ gcp windows 322 545
Test Name aws-ucws windows gcp linux
TestAccept βœ…β€‹p πŸ”„β€‹f
TestAccept/bundle/templates/default-python/integration_classic βœ…β€‹p πŸ”„β€‹f
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.11 βœ…β€‹p πŸ”„β€‹f
TestFsCpFileToDir πŸ”„β€‹f βœ…β€‹p
TestFsCpFileToDir/local_to_uc-volumes πŸ”„β€‹f πŸ™ˆβ€‹s

eng-dev-ecosystem-bot avatar Oct 13 '25 09:10 eng-dev-ecosystem-bot