cli
cli copied to clipboard
Normalize output paths when downloading files
Changes
The "bundle generate" suite of commands generate bundle configuration and download relevant files from the workspace to the local file tree. Some paths that are valid in the Databricks workspace are not valid on Windows. This change normalizes path components to always be Windows-compatible.
Why
Fix the class of issues demonstrated by #2528.
Tests
- New unit tests.
- Manually confirmed that running "bundle generate" for a pipeline with a source file that includes incompatible characters now works as expected on Windows.
This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled.
| Env | πβflaky | β βpass | πβskip | |
|---|---|---|---|---|
| β β | aws linux | 322 | 545 | |
| β β | aws windows | 323 | 544 | |
| β β | aws-ucws linux | 438 | 441 | |
| πβ | aws-ucws windows | 2 | 437 | 440 |
| β β | azure linux | 322 | 544 | |
| β β | azure windows | 323 | 543 | |
| β β | azure-ucws linux | 438 | 440 | |
| β β | azure-ucws windows | 439 | 439 | |
| πβ | gcp linux | 3 | 318 | 546 |
| β β | gcp windows | 322 | 545 |
| Test Name | aws-ucws windows | gcp linux |
|---|---|---|
| TestAccept | β βp | πβf |
| TestAccept/bundle/templates/default-python/integration_classic | β βp | πβf |
| TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.11 | β βp | πβf |
| TestFsCpFileToDir | πβf | β βp |
| TestFsCpFileToDir/local_to_uc-volumes | πβf | πβs |