Bundle deploy sync whl takes .gitignore into account on Windows

[daanschonberger]

Describe the issue

When deploying the bundle the main databricks.yml consists of the following snippet

sync:
    include:
      <path-to-whl>

This path is also in our .gitignore When deploying the whl package doesn't get included in the deployment to the workspace, when removing the path from the .gitignore it deploys just fine.

Configuration

databricks.yml consists of:

sync:
    include:
      - "./dist/*.whl"

.gitignore file:

dist/

Steps to reproduce the behavior

Please list the steps required to reproduce the issue, for example:

1. Run databricks bundle deploy -t d
2. Checking bundle path and omits dist folder with whl package

Expected Behavior

Expected to have the dist folder with a whl package even when in .gitignore

OS and CLI version

Since version 0.221 and above

Is this a regression?

Worked well before 0.221

Extra info: deployment via WSL/Linux works as expected Wildcarding the path without the dist folder also works like: *.whl

[andrewnester]

Hi! What if you try to specify the path is Windows-like format, - ".\\dist\\*.whl"? Does it work in this case?

[daanschonberger]

Hi Andrew, thanks for the swift reply. I did try that before, and it didn't work. Should have added it to the issue, my bad.

As said before, completely wildcarding the total path with *<name_of_whl> works fine so its a good workaround for now. It's not the highest prio. Just that documentation on the page is showing the desired way:

[andrewnester]

There might be something else happening, we just added a test which does exactly the same thing as described here and it succeeds on Windows https://github.com/databricks/cli/pull/1637/files#diff-418f3119cb19ecfc1735c31a665b37c455ac1ab2d6fa6baf2b1d353a86795584R123

Since it broke on version 0.221.0 a change which could cause it might be this https://github.com/databricks/cli/pull/1452 @pietern any thoutghts?

[MaciejReplin]

Any of you had luck with it? I have the same issue and few colleagues from my team. We have dist and packages folder in include list, however its in gitignore file. It does not get deploy with bundle.

[github-actions[bot]]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[pietern]

We should try to get a repro on Windows with an acceptance test.

[andrewnester]

While the fix is merged and release in 0.246.0 we have an issue with Windows releases and this fix is not yet available for Windows builds. In the meantime you can install Windows release directly from Github release binaries https://github.com/databricks/cli/releases/tag/v0.246.0

[andrewnester]

Windows releases are restarted and we have just released all missing and a new CLI version on Windows