pisanix icon indicating copy to clipboard operation
pisanix copied to clipboard

feat(strategy): add standard sharding config

Open wbtlb opened this issue 2 years ago • 1 comments

What is changed and how it works?

What's Changed:

  • add standard sharding config

wbtlb avatar Aug 17 '22 09:08 wbtlb

Codecov Report

Merging #267 (6fcede6) into master (df61eb4) will increase coverage by 3.32%. The diff coverage is 79.68%.

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   66.97%   70.30%   +3.32%     
==========================================
  Files           7        6       -1     
  Lines         427      495      +68     
==========================================
+ Hits          286      348      +62     
- Misses        133      137       +4     
- Partials        8       10       +2     
Flag Coverage Δ
unittests 70.30% <79.68%> (+3.32%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 58.62% <53.84%> (+0.72%) :arrow_up:
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) :arrow_up:
pisa-controller/pkg/proxy/builder.go 91.21% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 17 '22 10:08 codecov[bot]

Sharding configuration needs to be discussed again, eg.

pub struct StrategyKind {
    standard: Option<Vec<Strategy>>,
    complex: Option<Vec<Strategy>>,
    hint: Option<Vec<Strategy>>,
}
database_strategy: Option<StrategyKind>,

The above configuration should be redesigned.

xuanyuan300 avatar Aug 19 '22 00:08 xuanyuan300

Closed. Need further discussion.

mlycore avatar Aug 24 '22 09:08 mlycore