anonlink icon indicating copy to clipboard operation
anonlink copied to clipboard

Remove dependency on clkhash

Open hardbyte opened this issue 8 years ago • 1 comments

Currently a few e2e tests rely on clkhash for generating the bloomfilters.

While it is nice to do an integration test between the related libraries we shouldn't introduce a clkhash as a dependency just for the integration test.

They are also used in the benchmarking script, comment from @wilko77:

none of the benchmarks actually needs real CLKs, as all you measure is timing. You could easily fake CLKs by choosing them randomly. This would not require a clkhash dependency.

Aha! Link: https://csiro.aha.io/features/ANONLINK-73

hardbyte avatar Dec 14 '17 09:12 hardbyte

It's not quite as simple as @wilko77 suggests: the performance on randomly generated CLKs will be very different to performance on typical data (see sdc.pdf file shared in #linking on 29/1/2018).

unzvfu avatar Mar 20 '18 23:03 unzvfu

clkhash is listed as a test dependency

hardbyte avatar Nov 22 '22 21:11 hardbyte