dataall icon indicating copy to clipboard operation
dataall copied to clipboard

Trying to open an environment in new tab opens same window

Open voidwisp opened this issue 2 years ago • 1 comments

Describe the bug

CTRL+Clicking on Environment title opens it in the same window and not in a new tab.

How to Reproduce

  1. Go to environments
  2. Attempt to open an environment in a new tab by clicking ctrl+click on the environment name

Expected behavior

  1. Environment should open in a new tab

Your project

No response

Screenshots

No response

OS

N/A

Python version

N/A

AWS data.all version

2.0

Additional context

No response

voidwisp avatar Dec 18 '23 17:12 voidwisp

@zsaltys, We appreciate the heads-up. It appears that the current behavior you're observing is consistent with the default settings of Material UI's Link component and react router navigate() method. To address this issue, we can override the default behavior by implementing event listeners In EnvironmentListItem.js:

if (event.ctrlKey) {
  window.open(`/console/environments/${environment.environmentUri}`, '_blank');
} else {
  navigate(`/console/environments/${environment.environmentUri}`);
}

This should help resolve the issue you've raised. Let me know if you have any further questions or concerns!

itsmo-amzn avatar Jan 03 '24 16:01 itsmo-amzn