dataall
dataall copied to clipboard
data-dot-all
Download button from data.all UI for shared folders/tables
This feature has been requested by a customer. In their organization non-technical personas are also data.all users. These users will request access to data and will need to download the particular files shared with them.
Describe the solution you'd like At the moment in data.all users can get the files by getting AWS credentials and running AWS CLI commands against the S3 access point of the folder shared with them. But ideally, they would be provided a button "download" to get this files directly from the UI.
Describe alternatives you've considered This can be achieved in a similar way that the "Upload" functionality in the Dataset UI for Dataset owners.
- Add "download" button next to shared tables and folders (for example in the sharedItems table)
- Create API call and write boto3 call in S3 handlers.
Open question: should we download one file, the complete folder content, a fix number of files?
Additional context Add any other context or screenshots about the feature request here.
P.S. Please Don't attach files. Add code snippets directly in the message body instead.
Prioritizing for v2.2.0, if there is spare time in v2.1.0 we can triage and bump it up.
@dlpzx We would definitely not be interested in this feature for security reasons as it gives attackers a direct way to access data. I would like to ask that the permissions for this feature and the feature itself are behind a feature flag that can be enabled/disabled. This can be the default if we want to but we should release it in a state where it can be disabled.
Referencing https://github.com/data-dot-all/dataall/issues/360, I do think we will have interest in this feature, as despite the security concerns, it is a use case that we already regularly support with other platforms. One thing we have done in the past is to limit the number of rows that can be downloaded at a given time, so it's not so easy for someone to just select star grab all the data from a table and walk away with it. Ideally the CSV download would be a configurable feature, but also configurable in the maximum number of rows that can be downloaded for a query result. The idea being, that the CSV download would be for more ad-hoc usage / reporting, as opposed to bulk data export and data transfer (which would not be desirable).
We also had another set of use cases for CSV download that could be applied with such export support. It would be nice to be able to CSV export info about all the datasets in the catalog, or even your search result from the catalog (again, for reporting purposes, so teams can pass around the list of onboarded datasets, accounts that have been onboarded, etc.). Same for environments and organizations, and perhaps also available shares. This same functionality could be used in those cases as well. And future auditing feature where we can pull activity data from RDS can also benefit from this.
