dataall icon indicating copy to clipboard operation
dataall copied to clipboard

CICD Integration tests: new shares for pre-existing datasets

Open SofiaSazonova opened this issue 4 months ago • 0 comments

Feature or Bugfix

  • Feature

Detail

For group share and consumption role shares perform

  • [x] Create Share request
  • [x] Submit request without Items (not allowed)
  • [x] Add items to request
  • [x] Submit request
  • [x] Change request purpose
  • [x] Reject request
  • [x] Change reject purpose
  • [x] Approve request
  • [x] Request succeeded
  • [x] Item health verification
  • [x] Folder sharing validation (cal list objects via s3 accesspoint)
  • [x] Bucket sharing validation (cal list objects in s3 bucket )
  • [x] Table sharing validation (cal perform athena query: select * from db.table )
  • [x] Revoke items
  • [x] Folder sharing validation (no more access)
  • [x] Bucket sharing validation (no more access)
  • [x] Table sharing validation (no more access)
  • [x] Delete share

Tests are the same as for new shares for new datasets Fixtures are parametrised

Relates

  • #1376

Security

Please answer the questions below briefly where applicable, or write N/A. Based on OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

SofiaSazonova avatar Oct 04 '24 14:10 SofiaSazonova