dataall icon indicating copy to clipboard operation
dataall copied to clipboard

ecdsa dependency is subject to CVE-2024-23342 and should be upgraded

Open rbernotas opened this issue 1 year ago • 3 comments

Describe the bug

See https://github.com/advisories/GHSA-wj6h-64fc-37mp for the description of the vulnerability.

How to Reproduce

data.all is currently using ecdsa 0.18.0

deploy/custom_resources/custom_authorizer/requirements.txt:ecdsa==0.18.0

Expected behavior

No response

Your project

No response

Screenshots

No response

OS

n/a

Python version

n/a

AWS data.all version

v2.6

Additional context

No response

rbernotas avatar Sep 06 '24 22:09 rbernotas

Hi @rbernotas - thank you for raising this issue. We are aware of the current vulnerability and a determining the best way forward because as of now there is no patched version for the above and no planned fix.

To note in documentation of this vulnerability - 'ECDSA signature verification is unaffected'. @TejasRGitHub could you confirm how exactly we use ecdsa library in the custom authorizer today?

I see we do not explicitly reference ecdsa but it is a child dependency for other packages like python-jose

++ Additional Call Out: This vulnerability is specific to custom_auth use cases with data.all

noah-paige avatar Sep 10 '24 21:09 noah-paige

Hi @noah-paige , let me do some digging on this and get back to you on this gh issue

TejasRGitHub avatar Sep 10 '24 22:09 TejasRGitHub

Hi @noah-paige , did some digging on this website - https://pypi.org/project/python-jose/. If installing python-jose with cryptography like pip install 'python-jose[cryptography]' the dependencies which are installed for this package are -

cffi==1.17.1
cryptography==43.0.1
ecdsa==0.19.0
pyasn1==0.6.1
pycparser==2.22
python-jose==3.3.0
rsa==4.9
six==1.16.0

This list uses ecdsa==0.19.0 I will check and test on my aws deployed data.all to see if the custom auth still works as expected.

TejasRGitHub avatar Sep 17 '24 16:09 TejasRGitHub