dataall icon indicating copy to clipboard operation
dataall copied to clipboard

Add encryption and tag immutability to ECR repository

Open mourya-33 opened this issue 10 months ago • 2 comments

Feature or Bugfix

  • Bugfix

Detail

  • Currently the ecr repository created do not have encryption and tag immutability enabled which is identified by checkov scans. This fix is to enable both.

Relates

- <URL or Ticket>

Security

Please answer the questions below briefly where applicable, or write N/A. Based on OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes N/A
    • Is the input sanitized? N/A
    • What precautions are you taking before deserializing the data you consume? N/A
    • Is injection prevented by parametrizing queries? N/A
    • Have you ensured no eval or similar functions are used? N/A
  • Does this PR introduce any functionality or component that requires authorization? N/A
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms? N/A
    • Are you logging failed auth attempts? N/A
  • Are you using or adding any cryptographic features? N/A
    • Do you use a standard proven implementations? N/A
    • Are the used keys controlled by the customer? Where are they stored? No. This is with default encryption
  • Are you introducing any new policies/roles/users? N/A
    • Have you used the least-privilege principle? How? N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mourya-33 avatar Apr 26 '24 17:04 mourya-33

Looks good! I am doing a quick test and I will merge. Thank you so much for the contribution @mourya-33 :)

dlpzx avatar Apr 29 '24 06:04 dlpzx

Thanks @dlpzx . I will test this out on my end as well. Since i went with new deployment i did not notice this on my deployment.

mourya-33 avatar Apr 29 '24 14:04 mourya-33

The rename works @dlpzx . I pushed the change in pipeline.py to the same branch to rename the repo

mourya-33 avatar May 07 '24 21:05 mourya-33