dataall
dataall copied to clipboard
Add possibility to search to all team and environment dropdowns
I have access to a lot of environments and teams and these team and environment dropdowns are very long. There are multiple places where they are not searchable and are not sorted either. On the team invite modal the team search is sorted and searchable. I propose we use those components everywhere where we need to list teams or environments.
Hi @zsaltys, thanks for the issue. This feature is implemented in some of the select dropdowns, so we could make it the standards approach for all field selectors. We will pick it up based on bandwidth
There are multiple places where we list Environments, Teams and Consumption roles. Some can be implemented using reusable frontend components, while others are more peculiar and will be implemented as standalone frontend code snippets.
Environment + Teams + X lists:
- [X] RequestAccessModal.js (PR)
In (https://github.com/data-dot-all/dataall/pull/1347):
- [X] DashboardImportForm.js - using EnvironmentTeamDropdown
- [X] MLStudioCreateForm.js - using EnvironmentTeamDropdown
- [X] NotebookCreateForm.js - custom
- [X] OmicsRunCreateForm.js - using EnvironmentTeamDatasetsDropdown
- [X] DatasetCreateForm.js - custom
- [X] DatasetImportForm.js - custom
In this PR
- [X] PipelineCreateForm.js
- [X] PipelineEditForm.js - NOT NEEDED Skipped. The table dropdown implements a complex handlechange logic that breaks with Autocomplete. If needed we can revisit in the future
- PipelineEnvironmentCreateForm.js
- PipelineEnvironmentEditForm.js
Teams + X lists:
- [X] OrganizationTeamInviteForm.js ---> already implemented. It is slightly different than others, it allows items that are not in the list to passed to the API call. This is because users can invite teams they do not belong to to the orga.
- [X] ShareBoxList.js --> already implemented!
In PR views that use useGroups for groupOptions:
- [x] WorksheetCreateForm.js
- [x] EnvironmentCreateForm.js
- [x] OrganizationCreateForm.js
- [x] GlossaryCreateForm.js
In PR
- [x] DatasetEditForm.js
- [X] RequestDashboardAccessModal.js - already implemented, minor changes
- [X] EnvironmentTeamInviteForm.js - already implemented, minor changes
- [X] EnvironmentRoleAddForm.js
- [X] NetworkCreateModal.js
TODO: IMPROVEMENTS:
- [ ] Use noOptionsText (check if it fixes height of no options)
Closing this issue as it is implemented in a series of PRs:
- #1367
- #1368
- #1356
- #1347
@dlpzx - if there still remain any follow up tasks or enhancements that are "nice to have", let's open a separate issue for them