dataall icon indicating copy to clipboard operation
dataall copied to clipboard

Modal for adding share items does not have a close button

Open zsaltys opened this issue 1 year ago • 3 comments

The modal for adding new share items to a share does not have a close button something like an X at the top right corner. It can be closed by clicking outside of the modal. This is not intuitive and a confusing user experience. It also would be nice if it closed automatically if there's nothing else left to add. It would also be nice to have a button to add all share items at once..

  • add a close button to the share item modal
  • close automatically when there's nothing else left to add
  • add a button to add everything all at once

zsaltys avatar Jan 26 '24 12:01 zsaltys

Completely, this are good enhancements that would benefit any type of user in data.all. If bandwidth allows we will try to incorporate it in our next releases.

dlpzx avatar Jan 31 '24 14:01 dlpzx

@SofiaSazonova @noah-paige Does the Share Remake PR cover this? i did see this one of the demo but please confirm

anmolsgandhi avatar Jun 11 '24 02:06 anmolsgandhi

#1277 will have a Save & Close button

Since it is 1 edit view for both adding and revoking items - I do not know if it will be possible to support closing automatically whne there is nothing left to do

Currently #1277 does not support a button or similar mechanism to add everything at once

noah-paige avatar Jun 11 '24 03:06 noah-paige

Should we consider this issue for 2.7 as enhancement? @zsaltys @SofiaSazonova @anmolsgandhi @noah-paige

dlpzx avatar Jul 12 '24 07:07 dlpzx