dataall icon indicating copy to clipboard operation
dataall copied to clipboard

Revoking a share item should automatically delete it

Open voidwisp opened this issue 1 year ago • 1 comments

After you revoke a share item you still have to delete it. It seems like a completely pointless step. It would be nicer if revoking a share automatically deleted a share item.

voidwisp avatar Jan 26 '24 12:01 voidwisp

@zsaltys thanks for opening the issue!

I have only two considerations against auto-delete

  1. The customer may need this shares in future for audit, for example. We still can delete it, but we need to make sure, that all important information is saved for the history. I will check now, what exactly we store about data shares after they are deleted. UPD. This info is just deleted from database. So, @dlpzx what so you think, should we save it?
  2. We should eliminate (or sooth) human error here. May be it's better to add cool-down period after revoking access, e.g. 24 hours and only then delete the share. To complete this idea, may be we should add 'restore access' action, which can be done within 24 hours.

@dlpzx Any thoughts about it?

SofiaSazonova avatar Jan 29 '24 11:01 SofiaSazonova

If the revoke succeeded I am ok deleting the item, I think it simplifies the process. Would this something to be considered for 2.7 @zsaltys ?

dlpzx avatar Jul 12 '24 07:07 dlpzx